Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: regenerate with latest "ugorji/go/codec" #9494

Merged
merged 9 commits into from
Apr 9, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 27, 2018

Fix #8715.
Fix #9447.

/cc @anthonyfok

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f5c5640). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9494   +/-   ##
=========================================
  Coverage          ?   72.91%           
=========================================
  Files             ?      366           
  Lines             ?    31000           
  Branches          ?        0           
=========================================
  Hits              ?    22604           
  Misses            ?     6788           
  Partials          ?     1608
Impacted Files Coverage Δ
client/keys.go 91.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c5640...ab3f74f. Read the comment docs.

@gyuho
Copy link
Contributor Author

gyuho commented Mar 28, 2018

This will introduce backward incompatible change in v2 client, so won't be merged until #9447 (comment) is addressed.

Until then, users should just vendor client with same ugorji/go/codec git revision as etcd release branches.

@gyuho
Copy link
Contributor Author

gyuho commented Apr 9, 2018

No more breaking changes with ugorji/go@b4c50a2. Merging after CI greens.

@gyuho gyuho force-pushed the ugorji/go branch 3 times, most recently from e45f627 to 3031962 Compare April 9, 2018 18:23
@gyuho gyuho force-pushed the ugorji/go branch 3 times, most recently from 578ee1f to 478f0fd Compare April 9, 2018 20:13
@gyuho gyuho merged commit fe26434 into etcd-io:master Apr 9, 2018
@gyuho gyuho deleted the ugorji/go branch April 9, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants